@AdrianoEscarabote
Posted
Hi SEBAANA YUSUF SALIM, hope you're doing well! I loved how your project turned out, but I’ve got a few suggestions that could be useful:
We have to make sure that all the content is contained in a reference region, designated with HTML5 reference elements.
native HTML5 reference elements:
<body>
<header>This is the header</header>
<nav>This is the nav</nav>
<main>This is the main</main>
<footer>This is the footer</footer>
</body>
Since this project is only based on a single page component, there is no need for a h1 tag. It's always a good idea to prevent accessibility errors, so I believe it would be beneficial for you to add a "h1" in this component. Don't worry if you forget about "h1," though; it's a good practice for when you are developing larger sites.
<h1>HTML & CSS foundations</h1>
The rest is fantastic.
Hopefully, you'll find it helpful. 👍
Marked as helpful
@salehjoseph
Posted
Hi @AdrianoEscarabote ,
Thank you so much for your kind words and for taking the time to review my project! 😊 I really appreciate your thoughtful feedback and the suggestions you provided.
I see what you're saying about using native HTML5 reference elements to structure the content more effectively. I’ll definitely implement that into the project to keep it more semantically correct.
Regarding the <h1> tag, I completely agree with you. It’s important to maintain accessibility standards even in single-page components, and I’ll be sure to include it going forward. Thanks for pointing that out!
I’m always looking to improve, so I’m really grateful for your insights. If you have any more suggestions or if you'd like to collaborate on any future projects, I’d love to hear from you!
Looking forward to staying connected!
Best regards, Sebaana Yusuf
@AdrianoEscarabote
Posted
@salehjoseph No problem, you did a great job, looking forward to seeing more challenges !!
@salehjoseph
Posted
Hey @AdrianoEscarabote, Thank you so much for the encouragement! 😊 I really appreciate it. I’m definitely excited to take on more challenges and improve with each one. Looking forward to staying connected and seeing your awesome work as well!
