Design comparison
Solution retrospective
I would use more css variables to handle repetitive rules
What challenges did you encounter, and how did you overcome them?None
What specific areas of your project would you like help with?None
Community feedback
- @Alex-Archer-IPosted 4 months ago
Hi!
Great work, congrats =)
I can suggest you to use
rem
for font sizes instead of pixels. And also you doesn't have to wrap image and paragraph into divs - you can style it directly =)Marked as helpful0@rodrigoroninPosted 4 months ago@Alex-Archer-I
Thanks for the feedback, Alex. I did some changes a couple of minutes ago to use em instead of pxs.
I have a tendency to wrap isolated elements in divs or sections (I changed the divs to sections, too), for me this is better and easier to read.
Maybe in a bigger project I should get rid of it for the sake of project size.
1@Alex-Archer-IPosted 4 months ago@rodrigoronin
Yeah,
em
better than pixels, but I still suggest you to chooserem
=)You see,
rem
takes it's values from the root of the page whileem
- from the parent element. So in bigger projects it's easy to skip moment when values of many nested elements began to change. That's whyem
is used quite rarely.I see why you tend to create separate sections, and it really isn't a big deal in small projects like this. It's just browser will parse every tag in the special object while the rendering, so in really big projects it could be bad for optimization.
And yes, semantic tags is better than divs =)
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord