P
Ruben de Man• 250
@developer-ruben
Posted
Hi!
Great component, here are my tips:
- I would not use article in sections, articles are used to have a more independent role rather than sections. More info here: https://www.smashingmagazine.com/2022/07/article-section-elements-accessibility/
- For timestamps you can use the <time> html tag. More info here: https://www.w3schools.com/tags/tag_time.asp#:~:text=The%20tag%20defines%20a,can%20produce%20smarter%20search%20results
- card__container--img is an invalid BEM class since you used img as an modifier, to rather change it into card__img to keep the BEM method in place.
- Try using css variables with for example colors, so you dont have to repeat them in your code
That's pretty much it! Best, Ruben
Marked as helpful
0
soybrrraian• 80
@imbraian
Posted
Hello Ruben! I apologize for my level of English, I am not a native speaker. I want to thank you from the bottom of my heart for your advice. I appreciate the time you took to provide feedback on my component. I am completely grateful. I will take your advice into account to improve more every day. Have a good day, my friend! @developer-ruben
1
