Design comparison
Solution retrospective
I'm especially proud of having been able to complete the challenge despite the difficulties I faced. However, in hindsight, I believe I have not yet given my 100%. I think I'm capable of doing things better. Next time, I will focus on doing even better than the previous time and so on consecutively to improve every day.
What challenges did you encounter, and how did you overcome them?I didn't see any other challenges. I didn't have time. But I will do all the ones that come my way.
What specific areas of your project would you like help with?In this project, I would like to receive specific help in:
Accessibility: I would like to make the project more accessible for people with disabilities, ensuring compliance with web accessibility standards. Code improvement: If there are areas in my code that could be improved in terms of clarity, efficiency, or maintainability, I would love to receive suggestions and guidance on that.
Any help or advice in these areas would be greatly appreciated. Thank you in advance for your help and support!
Community feedback
- @developer-rubenPosted 8 months ago
Hi!
Great component, here are my tips:
- I would not use article in sections, articles are used to have a more independent role rather than sections. More info here: https://www.smashingmagazine.com/2022/07/article-section-elements-accessibility/
- For timestamps you can use the <time> html tag. More info here: https://www.w3schools.com/tags/tag_time.asp#:~:text=The%20tag%20defines%20a,can%20produce%20smarter%20search%20results
- card__container--img is an invalid BEM class since you used img as an modifier, to rather change it into card__img to keep the BEM method in place.
- Try using css variables with for example colors, so you dont have to repeat them in your code
That's pretty much it! Best, Ruben
Marked as helpful0@imbraianPosted 8 months agoHello Ruben! I apologize for my level of English, I am not a native speaker. I want to thank you from the bottom of my heart for your advice. I appreciate the time you took to provide feedback on my component. I am completely grateful. I will take your advice into account to improve more every day. Have a good day, my friend! @developer-ruben
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord