Blog Preview Card

Community feedback

• 

  P

  Øystein Håberg•10,670

  @Islandstone89Posted 9 months ago

  HTML:

  • Every webpage needs a <main> that wraps all of the content, except for <header> and footer>. This is vital for accessibility, as it helps screen readers identify the "main" section of a page. Change .container into a <main>.

  • Wrap the date in a <time> tag:<time datetime="2023-12-21">21 Dec 2023</time>.

  • The profile image has meaning, so it must have proper alt text. Write something short and descriptive, without including words like "image" or "photo".

  CSS:

  • It's good practice to include a CSS Reset at the top.

  • Add around 1rem of padding on the body, so the card doesn't touch the edges on small screens.

  • To center the card horizontally and vertically, use Flexbox on the body:

  display: flex;
  flex-direction: column;
  justify-content: center;
  align-items: center;
  min-height: 100svh;
  

  • On .container, remove width, position, top, left, transform and min-height.

  • Add a max-width of around 20rem on the card, to prevent it from getting too wide on larger screens.

  • font-size must never be in px. This is a big accessibility issue, as it prevents the font size from scaling with the user's default setting in the browser. Use rem instead.

  • I don't see the need for a media query on this challenge. When needed, they must be in rem, and you should do mobile styling as the default.

  Marked as helpful

  1

  ---

  

  Mohamed Ashraf•300

  @hamody-74Posted 9 months ago

  @Islandstone89 Thanks mate, next time I will make these changes :)

  1
• 

  Souhail•510

  @SouhailM07Posted 9 months ago

  Hello Developer , i can make your project look better and optimize it .

  Marked as helpful

  0