Design comparison
SolutionDesign
Community feedback
- @Mohammed-NedjimaPosted 5 months ago
Hello there! Congrats 🎉 for completing this challenge and I wish you an exciting journey as a frontend developer. Your work looks great overall but there is some advice you can use to improve yourself:
- It's better to put the title tag at the top of the head element for performance reasons, it should be the first thing to be rendered.
- Try to use descriptive class names. Instead of pic, pic1, container-sub, yellow, and small, use image, illustration, card-content, card-tag, card-release, and so on. It won't make a difference in small tasks like this, but you should practice for bigger projects when you work with other developers. It's also good for yourself since it makes the code more readable. -NEVER USER PIXELX FOR FONT SIZES, this is a common mistake at the beginning of your path. The reason for this is that rem values are changeable according to the user's browser settings. unlike pixels which are fixed-size. -It's better to edit the readme file with some details about the challenge how did you go through the challenge and what difficulties you encountered. You are not obliged to keep the links of frontendmentor on the button of your HTML file.
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord