Design comparison
Community feedback
- @R3ygoskiPosted 6 months ago
Hello Nayara, congratulations on completing this challenge! Your solution looks almost identical to the proposed design, well done!
I'd like to give you some tips, starting with CSS. It's not a good practice to keep CSS within the index.html file, as it makes maintenance difficult and ends up cluttering the HTML. I recommend trying to use your CSS in a separate external file.
To do this, it's very simple. Check out the "External CSS" section on W3School - CSS.
Another tip I'd like to give you is regarding font sizes. Try using the rem unit instead of px. This is because rem adapts to the user's font settings, making your project more accessible.
Now, about accessibility, another way to keep your project accessible is by using headings in the correct order, without skipping heading levels. For example, I noticed you used
<h6>
, but it would be more appropriate to use<h2>
. If you'd like to learn more about this, here's a link: W3SChool - Heading Level.To avoid accessibility errors, I recommend replacing the
<div>
you used with<main>
, as that is the main content area.Once again, congratulations on completing your project. If you have any questions, please ask below, and I'll try to help as best as I can.
Marked as helpful1@Nayara-CPosted 6 months ago@R3ygoski
Thank you for your feedback and valuable tips! I appreciate your suggestions for improving my code and making it more maintainable and accessible. I will definitely take your advice on board and work towards implementing these changes in my future projects.
Thanks again for taking the time to review my project and provide helpful recommendations. I'm committed to continually improving my coding skills and producing high-quality work. If I have any questions or need further clarification, I'll be sure to reach out.
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord