Design comparison
Solution retrospective
Feedbacks are welcomed. Thank you.
Community feedback
- @MelvinAguilarPosted 10 months ago
Hello there π. Good job on completing the challenge !
I have some suggestions about your code that might interest you.
HTML π·οΈ:
- Use semantic elements such as
<main>
and<footer>
to improve accessibility and organization of your page.
- Always avoid skipping heading levels; Starting with <h1> and working your way down the heading levels (<h2>, <h3>, etc.) helps ensure that your document has a clear and consistent hierarchy. Source π
CSS π¨:
- Instead of using pixels in font-size, use relative units like
em
orrem
. The font-size in absolute units like pixels does not scale with the user's browser settings. Resource π.
I hope you find it useful! π
Happy coding!
Marked as helpful1@Enthroned07Posted 9 months agoThank you very much for your suggestion, i'll make improvement. @MelvinAguilar
0 - Use semantic elements such as
- @danielmrz-devPosted 10 months ago
Hello @Enthroned07!
Your project looks great!
I noticed that you used
margin
to place the card in the middle of the page. Here's a very efficient (and better) way to center the card:- Apply this to the body (in order to work properly, don't use position or margins):
body { min-height: 100vh; display: flex; justify-content: center; align-items: center; }
I hope it helps!
Other than that, great job!
Marked as helpful0@Enthroned07Posted 9 months agoThanks so much for the advice, i'll definitely put it to use next time. @danielmrz-dev
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord