Design comparison
Solution retrospective
I'm proud of the fact that I was able to style my CSS in a structured manner
What challenges did you encounter, and how did you overcome them?I was kind of confused about how I'm supposed to set the width of the containers. So I decided to put absolute values for some, and relative values for others depending on the container level.
What specific areas of your project would you like help with?I would like to know how you are supposed to set the width of the containers. Should you put an absolute value like width:350px or should you put a value like width: fit-content?
Community feedback
- @0xabdulkhaliqPosted 8 months ago
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have a suggestion regarding your code that I believe will be of great interest to you.
HEADINGS ⚠️:
- This solution lacks usage of
<h1>
so it can cause severe accessibility errors due to lack of level-one headings<h1>
- Every site must want only one
h1
element identifying and describing the main content of the page.
- An
h1
heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.
- So we want to add a level-one heading to improve accessibility by reading aloud the heading by screen readers, you can achieve this by adding a
sr-only
class to hide it from visual users (it will be useful for visually impaired users)
- Example:
<h1 class="sr-only">Blog preview card</h1>
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
0 - @viktorhristov0Posted 8 months ago
Great solution. Just one small thing if you look closely at the example preview-card's paragraph text you can see that there is space in-between the lines. I added space in-between the lines by using "line-height: 1.4;" in CSS.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord