Blog preview card

Community feedback

• 

  P

  Kamran Kiani•2,740

  @kaamiikPosted about 2 months ago

  • Wrap a inside the h1 not the opposite.

  ---

  • The alt should be empty for both images. Do not use words like image or picture inside your alt text. It's obvious that screen reader describing the image. You can read more about how to add a good alt text here: https://www.craigabbott.co.uk/blog/how-to-write-good-alt-text-for-screen-readers/

  ---

  • Your font-size and max-width should be in rem unit not px. You can read this article about it and why you should not use px as a font-size.

  ---

  • No need for this: width: 100%;

  ---

  • Use min-height: 100vh; instead of height:100vh;. height: 100vh strictly limits the height to the viewport size, potentially causing overflow issues if the content is larger than the viewport. On the other hand, min-height: 100vh allows your element to grow in height if the content exceeds the viewport size.

  Marked as helpful

  0

  ---

  

  KrisvHeij•50

  @KrisvHeijPosted about 2 months ago

  @kaamiik Thanks for your comments, I appreciate it!

  0
• 

  aleks540•50

  @aleks540Posted about 2 months ago

  Great work! thumbs up :)

  0