Design comparison
Solution retrospective
- What did you find difficult while building the project? ans: font size and weight
- Which areas of your code are you unsure of? ans: nothing
- Do you have any questions about best practices? and: no
Community feedback
- @danielmrz-devPosted 10 months ago
Hello @UzzalPahan!
Your solution looks great!
I have a suggestion for improvement:
- Use
<main>to wrap the main content instead of<div>.
š Think of
<div>and<span>in HTML like plain boxes or placeholders. They're handy for holding content, but they don't tell us anything about what's inside or what it's meant for on the webpage.This tag change does not impact your project visually and makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.
I hope it helps!
Other than that, great job!
0 - Use
- @hassanmoaaPosted 10 months ago
Hello @UzalPahan!
Great Job solving the challenge mate congrats š
Some suggestions for improvements.
For the font-size it's is recommended to use rems and ems.
font-size: 13px;i see you using pixels for many elements, never use pixels for font-sizes in any element, here's why:
Certain font-related CSS properties will render your site completely inaccessible if their value is declared using pixels even once.
Which properties are affected?
All of these properties must never ever be declared in pixels:
- font-size
- line-height
- letter-spacing
If you've used pixels to define any of the above style properties, these will not respect the user's font size preferences!
You should use ems, and rems for font-sizes would be better
This article may help:
(https://fedmentor.dev/posts/font-size-px/)
āāāāāāāā
Use
<main>to wrap the main content instead of<div>. * š Tags like <div> and <span> are typical examples of non-semantic HTML elements. They serve only as content holders but give no indication as to what type of content they contain or what role that content plays on the page. This tag change does not impact your project visually and makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.āāāāāāā
Other than that you're good, keep up the good work!
0@UzzalPahanPosted 10 months ago@hassanmoaa thank you for find out the weakness. I will try to improve myself
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord