Design comparison
Solution retrospective
My solution for this easy but nice challenge in React and Tailwind. Please, write me some feedback, it will be very helpful for me. Thanks :)
Community feedback
- @MelvinAguilarPosted 11 months ago
Hello there ๐. Good job on completing the challenge !
The React and Tailwind code is excellent. You even used the dynamic viewport units introduced in the latest version of Tailwind. I just have a small suggestion regarding the HTML.
-
The
<article>
tag is typically used to represent a self-contained piece of content that could be distributed and reused independently. If the content inside the<article>
tag is not a standalone piece, or if it doesn't represent an independent piece of content you might want to reconsider using the<article>
tag. It's not necessary to use the <article> tag for the photo or to group the person's image. -
The
alt
attribute should not contain the words "image", "photo", or "picture", because the image tag already conveys that information. -
When you use the hover effect and cursor: pointer on an element, it usually implies interactivity. To enhance user experience, consider wrapping the title of the "HTML & CSS foundations" text in an
<a href="#">
tag.
I hope you find it useful! ๐ Above all, the solution you submitted is great!
Happy coding!
0@Anette23Posted 10 months ago@MelvinAguilar Thank you for your feedback! I really appreciate it. ๐ I typically use the <article> or <aside> tags to avoid using <div> tags. ๐ Is that a significant mistake?
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord