Design comparison
Solution retrospective
- Try to be a little bit more carefull when styling the components
- It was hard to get all the content right
- I had problems styling all the content
- Help on the styling if theres is ways to improve
Community feedback
- @stephany247Posted about 1 month ago
Excellent job! You're demonstrating impressive skills here. Your use of semantic HTML is highly commendable. I have just a few small suggestions that could help make this even better...
-
One area to consider is the line-height; using a percentage 150% can sometimes lead to inconsistent results. Using a unit like em or rem might provide more predictable outcomes.
-
To make your code cleaner and more maintainable, try to avoid repetition. For example, I noticed that the attribution class styles were defined in both your internal and external CSS. Keeping styles DRY (Don’t Repeat Yourself) can help reduce file size and complexity. Additionally, look for opportunities to consolidate repetitive styles. This will make your stylesheet easier to read and manage.
I hope you find this feedback helpful! Keep honing your skills and embracing new challenges with confidence. You're making fantastic strides—stay motivated and continue coding with passion! 💻
Marked as helpful0 -
- @faizraeimPosted 14 days ago
Your code is great, you only forgot to add shadow to the container, it can be done with
box-shadow: 10px 10px;
.0 - @korizstPosted about 1 month ago
It looks like a good solution. Just a question. You have CSS rules in two separate files (reset.css, style.css) and in HTML. Why didn't you put them in one file?
0@rodrigoo-alvesPosted about 1 month ago@korizst i kinda learned this way and helps other people who dont understand whats happening on the code
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord