Design comparison
Solution retrospective
Please provide feedback on my code
Community feedback
- @danielmrz-devPosted 9 months ago
Hello @rlboogey!
Your project looks great!
I have one suggestion for you to improve it even more:
- Using
position: absolute
is not the best option to center an element. It can cause bugs and may result in part of the content being cut off on smaller screens.
Here's a very efficient (and better) way to place an element in the middle of the page both vertically and horizontally:
๐ Apply this to the body (in order to work properly, don't use position or margins):
body { min-height: 100vh; display: flex; /* it works with grid too */ justify-content: center; align-items: center; }
I hope it helps!
Other than that, great job!
0 - Using
- @AlexanderEstebanZapata1994Posted 9 months ago
Hi, I have some advices to you
You could add the box shadow to your main container, the box shadow property could be like box-shadow: 10px 10px 1px black;
Take into account to add the author profile picture and the name.
For your published label, could you remove the bold style and set an smaller font size.
Other thing, I was reviewing your code and you use a div for every section, you could use the elements tagged like main, footer, article and so on, to have a better structure in your web design.
Instead of use font-family for every element you need, you could set font family in your either body, html or * in your style.css file.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord