Submitted 9 months ago

Blog preview card

keremenen• 270

@keremenen

Preview site(opens in new window)View code(opens in new window)

This is a solution for...

Blog preview card

HTML
CSS

1newbie

View challenge

Design comparison

SolutionDesign

Solution retrospective

I will be very happy to get any feedback. :)

Community feedback

Øystein Håberg• 10,130

@Islandstone89

Posted 9 months ago

Hi, well done!

Here are some suggestions:

HTML:

Don't include "image" in the alt text, as screen readers announce it as an image automatically.
Wrap the date in a <time> element: <time datetime="2023-12-21">21 Dec 20223</time>.
For the profile image, an alt text like "Headshot of Gary Hooper" would be more suitable.

CSS:

Performance-wise, it's better to link fonts in the <head> of the HTML than using @import.
It's good practice to include a CSS Reset at the top.
Add around 1rem of padding on the body, so the card doesn't touch the edges on small screens.
max-width on the card should be in rem.
font-size must never be in px. This is bad for accessibility, as it prevents the font size from scaling with the user's default setting in the browser. Use rem instead.
Media queries must be in rem. Also, it is common to do the mobile styling as the default.

Marked as helpful

keremenen• 270

@keremenen

Posted 9 months ago

@Islandstone89

Tons of usefull advices. Im gonna use them in my next project.

Thank you a lot!

Alok Suman• 2,380

@Alokray007

Posted 9 months ago

Hello there 👋

Good job on completing the challenge !

Your project looks really good!

I have a suggestion about your code that might interest you.

There is an very useful browser extension called Perfect Pixel that allow you compare with the design image and thus see the exact dimensions. I recommend it to you.

📌 Tags like <div> and <span> are typical examples of non-semantic HTML elements. They serve only as content holders but give no indication as to what type of content they contain or what role that content plays on the page. This tag change does not impact your project visually and makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.

I hope this suggestion is useful for future projects.

Other than that, great job!

Happy coding.

Marked as helpful

keremenen• 270

@keremenen

Posted 9 months ago

@Alokray007

Thank you for your feedback. I've just installed the plugin and it seems to be great. Im gonna try it in next challenges. Also thanks for the advice with semtantic HTML elements - gonna use them more.

Once again, thanks. :)

Please log in to post a comment

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord