@jacob-stone9554
Posted
Hi Emmanuel, your solution looks great I really like what you've done with it!
As far as the style of your solution goes, I don't have any feedback, you are almost spot on with your design. I really like the active states when you hover over the different aspects of your solution, it's a fun implementation :)
One way I think you could improve is with the structure of your HTML. I see that you have semantic HTML in your solution which is good! But the order in which they are used could be a little confusing to follow. For example, in your <div class="card"> on line 30, you have a <figure> and <main>. These are both components of semantic HTML, which is good for you to be using. However, they aren't being used in the way they were necessarily intended. Generally, <main> should be used to container the main content of your page, like a <figure> and is generally found below a <header> and above a <footer>.
If you'd like to read more about it, here is a link with some basic information about semantic HTML.
I hope this helps, feel free to reach out if you have any questions. Happy coding!!
Marked as helpful
@EMLzmile
Posted
Hi @jacob-stone9554, thank you for this feedback, I will take it into account during my next challenges and projects. code readability is important for better understanding. thank you again for the link which allowed me to better understand the use of HTML semantic elements 😁
