Design comparison
Solution retrospective
I have solved this challenge and I have learned many things on this project.
What challenges did you encounter, and how did you overcome them?I have not faced any challenges on this project.
What specific areas of your project would you like help with?No other.
Community feedback
- @turanarican2022Posted 9 months ago
Hello, I reviewed your code and here my opinions;
-
it looks good generally but you could have used semantic elements. You can change container div with <main> and the attribution div with <footer>
-
you used a button for the yellow "Learning" tag which in my opinion is not a good practice at all. I would prefer simply a <span> whose display is set to inline-block. Buttons should instead be used for "triggering actions" like form submit or opening a modal window.
-
spacing and sizes require some adjustments like avatar image and text are too large. The most important is "description text" would be much nicer with some line-height added.
Nevertheless good job. Keep up! Happy coding!
1 -
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord