turanarican• 200
@turanarican2022
Posted
Hello, I reviewed your code and here my opinions;
-
it looks good generally but you could have used semantic elements. You can change container div with <main> and the attribution div with <footer>
-
you used a button for the yellow "Learning" tag which in my opinion is not a good practice at all. I would prefer simply a <span> whose display is set to inline-block. Buttons should instead be used for "triggering actions" like form submit or opening a modal window.
-
spacing and sizes require some adjustments like avatar image and text are too large. The most important is "description text" would be much nicer with some line-height added.
Nevertheless good job. Keep up! Happy coding!
1
