@dongmo-shu
Posted
Hello @Muhammed61699
Congratulations on completing the challenge. Your solution looks great.
Here are some feedbacks I have to improve your code.
First
Always include your <div> inside an HTML landmark. for your solution, have all <div> inside of your <body>, enclosed in the landmark <main>. You can read about HTML landmarks, and their importance in this article
Second
When it comes to media queries, I recommend using the unit of measurement rem instead of px. You can read more in this article by FreeCodeCamp.
Third
To have your solution at the centre of the page, I recommend you add this.
body{
min-height: 100vh;
display: flex;
align-items: center;
flex-direction: column;
justify-content: center;
}
I hope this is useful.
Marked as helpful
@Muhammed61699
Posted
@Singraft Thank you so much for your feedback I really appreciate it; It is very useful I will apply all your recommendations. Thanks again.
