Design comparison
Solution retrospective
I am most pleased with being able to match my solution with that of the preview to the best of my ability. The one I would do differently is starting with the HTML before moving on to the CSS portion as by not doing that I had to rework my solution from scratch.
What challenges did you encounter, and how did you overcome them?The challenges I encountered had to do with the styling, fonts, and width of the card itself. The Figma design helped me greatly in this case, as I was able to get the appropriate margins, padding, and sizes to ensure that my solution closely resembles that of the preview.
What specific areas of your project would you like help with?Feedback regarding my font sizes and weights would be greatly appreciated, especially regarding the "Learning" text. I want to know how I can better match the font weights of the preview.
Also I would like some help on my avatar not showing up on Github pages even though it worked fine using Live Server on Visual Studio Code
Community feedback
- @danielmrz-devPosted 8 months ago
Hello @BluffSet7340!
Your solution looks great!
I have a suggestion for improvement:
š Think about using
<main>
to wrap your main content instead of<div>
.Imagine
<div>
and<span>
in HTML as basic containers. They're good for holding stuff, but they don't tell us much about what's inside or its purpose on the webpage.This change might not have impact on how your page looks, but it'll make your HTML code clearer and help with SEO and accessibility.
Hope that's helpful!
Keep up the great work!
Marked as helpful1@BluffSet7340Posted 8 months ago@danielmrz-dev I appreciate the feedback, especially the part about the main tag and how it improves SEO and accessibility. I'll be sure to implement the <main> more often in later solutions.
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord