Design comparison
SolutionDesign
Community feedback
- @silkcoderPosted 10 months ago
Hello there,
Your solution looks very good, I have a few suggestions.
The container is not centered vertically, to place the container vertically center, just add the following style to your .container class
.container { //add this property to your existing styles min-height: 100vh; }
Now you can remove margin-top property from .box class
.box { //remove this style margin-top: 50px; }
I checeked the repo and I think its good to place your assets in separate folders, like images goes to 'images' folder and css files to you a 'css' folder.
It is not a good practice to add inline styles to an HTML element (you added inline styles to a div with class box)
Good luck with your future tasks
Good day
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord