Design comparison
SolutionDesign
Community feedback
- @BlackpachamamePosted 10 months ago
Greetings! you have done a great job š
š Some accessibility and semantics recommendations for your HTML
- To improve the semantics of your HTML, you can change your
<div class="attribution">
to a<footer class="attribution">
š Some suggestions
- Add a
padding
to generate interior space on your card. This prevents you from usingmargin
orpadding
on child elements to achieve the same result - Use
min-height
andmax-width
, this will help the content stretch or shrink if you need to. Unlikeheight
andwidth
which can cause your content to be cut off on certain screens - You can apply the properties you placed in the
main
directly to thebody
. In this way, thefooter
will also be included and the vertical scroll will no longer be generated. Then you can remove themain
and change thesection
tomain
. I don't know if I explained the latter correctly š
Marked as helpful0 - To improve the semantics of your HTML, you can change your
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord