P
Kamran Kiani• 1,040
@kaamiik
Posted
Hi. I have some notes that I wanna mention:
- There is no need to use
article
andsection
tag here. It's Just a card and can be deployed using adiv
tag`. - Your
img
is decorative and does not need any alt text message. - I think Learning is not a button and can be
a
tag because It takes you to the new page if It is a tag. - You can not use a text inside a
div
. Try a semantic tag likep
. - It's not necessary to wrap everything in a
div
. Do it when you have to. - Still I see some other problems. Better to revisit your html.
- On CSS, You need a good CSS reset. Andy Bell is good.
- Your page is not responsive. If you resize the screen size it overflows. Because you restricted your
width
andheight
. Never ever do this. You can do this only for some image and logos. - You have to use
rem
unit for font size and also for spacing you can useem
too. and also for usingmax-width
and media query you have to userem
unit.
0
Pichikachandu• 90
@Pichikachandu
Posted
@kaamiik thank you for your clarification iam just a beginner I will rectify those mistakes
1
P
Kamran Kiani• 1,040
@kaamiik
Posted
Yw :) Try to ask more question on discord community If you are hesitate in some part of your code. Mentors can help much better. @Pichikachandu
0
Pichikachandu• 90
@Pichikachandu
Posted
@kaamiik of course thank you so much
0