Design comparison
Community feedback
- @klb-devPosted 4 months ago
Great job on the design and coding so far. Your efforts are evident and appreciated. The code is clean, but why not use <button> or <a> for the learning button? You placed it in <p>. The heading should be an <h1> as well. These tags are done for screen readers and people with visibility issues. Your avatar image does not show up even though it looks correct. Placing a '.' before the first '/' would make it work.
CSS looks good; maybe start with mobile first and then have fewer media queries to produce more DRY code—great job with styling.
Marked as helpful0@TharunkumarsubburajPosted 4 months ago@klb-dev thanks for your comment i will correct them in the upcomming project and on this also
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord