Design comparison
Solution retrospective
Building this project significantly improved my coding skills by immersing me in the practical application of HTML and CSS.
Any Suggestion ? Or Feedback ?
Thank You.
Community feedback
- @MelvinAguilarPosted 11 months ago
Hello there 👋. Good job on completing the challenge !
I have other suggestions about your code that might interest you.
- Wrap the page's whole main content in the
<main>tag.
- For icons, you should still use the alt attribute, but it should be empty (
alt=""). This indicates to screen readers and other assistive technologies that the icon is decorative and that they should skip over it
- For a photo of a person, use their name as the alt text. Also, to make the alt attribute as useful and effective as possible, avoid using words such as "image", "SGV", "photo", or "picture" as they are redundant because the image (
<img>) tag already conveys that information
I hope you find it useful! 😄
Happy coding!
Marked as helpful0 - Wrap the page's whole main content in the
- @danielmrz-devPosted 11 months ago
Hello @miteshp98!
Your solution looks pretty good!
I have one sugesstion:
- Avoid setting fixed height values for the card. Most projects lije this, you don't need to worry about setting the height of the element. You just add the content and it adapts to fit it all in.
When you set a fixed value and it's not enough to fit the content, part of it can leak from the card. This is currently happening to your project.
- Also, place the footer outside the card, so it won't take up space unnecessarily on the card.
I hope it helps!
Other than that, great job!
Marked as helpful0 - @AhlamAb22Posted 11 months ago
Good work!
Here are a few suggestions:
-Try to use classes for styling instead of directly styling elements.
-Implement a CSS reset.
-Avoid using Px for font-size
-Avoid specifying fixed heights and widths; try using 'max-height' and 'max-width' for flexibility.
Marked as helpful0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord