Design comparison
Solution retrospective
This is my first challenge is about a year, so I am a little rusty. Any feedback would be appreciated.
Community feedback
- @danielmrz-devPosted 11 months ago
Hello @JGedd!
For someone who considers himself rusty, you did an excelent job! 😊
I have just two minor suggestions:
- First: Replace your
h2
withh1
. The choice of ah1
toh6
tag is not just about the size of the text.
The
<h1>
to<h6>
tags are used to define HTML headings.<h1>
defines the most important heading.<h6>
defines the least important heading.Only use one
<h1>
per page - this should represent the main heading/subject for the whole page. Also, do not skip heading levels - start with<h1>
, then use<h2>
, and so on.- And second: Just a detail. The card has a
box-shadow
, which you did correctly, but it also has a very thinborder
. Something likeborder: 1px solid black;
should be enough.
I hope it helps!
Other than those details, you did a great job! 😊
And Happy New Year! 🎉
Marked as helpful0 - First: Replace your
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord