Blog preview card

Community feedback

• 

  Marcos Travaglini•6,210

  @BlackpachamamePosted about 1 month ago

  Your project looks correct, but I have some questions:

  • Why add object-fit: cover to images without a container that "contains" them? If you remove this property, does it affect the images or the rest of the content?
  • A section inside another section... looks weird
  • The time tag only contains the date/time, but not the rest of the text. More info
  • In my opinion, it is simpler to manipulate the card elements by resetting the margin that some HTML tags have by default. So I would apply * {margin: 0;}. But that's just my point of view

  Marked as helpful

  0

  ---

  

  👾 Ekaterine Mitagvaria 👾•7,780

  @catherineisonlinePosted about 1 month ago

  @Blackpachamame Hey, thanks for the feedback. In my case, you are right, I don't need object-fit because I didn't set a fixed height for the image. However, what do you mean by container? As far as I know, you can use object-fit directly with the img and it doesn't need to be wrapped in anything.

  Thanks for the rest of the tips!

  1

  

  Marcos Travaglini•6,210

  @BlackpachamamePosted about 1 month ago

  @catherineisonline You're right, until now I had used object-fit by placing the img inside a container (figure for example) and adding the overflow: hidden property. Now I know it's not necessary, thanks! 😁

  0

  

  👾 Ekaterine Mitagvaria 👾•7,780

  @catherineisonlinePosted about 1 month ago

  @Blackpachamame Got it, always learning something new 😁

  1