
Design comparison
SolutionDesign
Solution retrospective
What specific areas of your project would you like help with?
I’d love to get some general feedback on my code, including tips and best practices to help me improve.
Community feedback
- P@KonradJamPosted 26 days ago
Hi @Trischa-99! You did a good job!
A few tips:
- You could improve your HTML semantics. The whole component should be wrapped with an
<article>
tag, and all text with a<section>
tag. - For text, use text tags like a header
<h1>-<h6>
or a paragraph<p>
. - Start using relative units like
em
orrem
for describing sizes of elements - Also in the description for this challenge was mentioned to make a fluid typography without a media query. You could achieve this by using the CSS clamp() function.
0 - You could improve your HTML semantics. The whole component should be wrapped with an
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord