Design comparison
Solution retrospective
Please check my design here
Community feedback
- @ZukizukPosted 10 months ago
Hello there, Congratulations on completing this project!
Your solution looks nice
I have a few suggestions that I think might be of interest to you.
- HTML: Consider using semantic HTML tags like
<main></main>
,<section></section>
and others that you can find in this link. And in this case, replace<div class="container">
with<main class="container">
. The main tag should hold the main content of the page so consider correcting that.The semantic HTML tags help search engines and other user devices determine the importance and context of web pages. The pages made with semantic elements are much easier to read. It has greater accessibility. It offers a better user experience. Using div when there's a better alternative is not a good practice as div holds no semantic value.
CSS: Also, you need to reset your style sheet at the start of your webpage before you start actually styling your webpage. Like this
* { margin: 0; padding: 0; box-sizing: border-box; }
Consider using the above code at the start of your CSS file to reset the stylings for you before you begin.
I hope this feedback is helpful.
Other than that great job
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord