Design comparison
SolutionDesign
Solution retrospective
tried this out in between lunch what do y'all think
Community feedback
- @MelvinAguilarPosted 10 months ago
Hello there ๐. Good job on completing the challenge !
I have some suggestions about your code that might interest you.
- The result is identical to the design, there are many hours behind achieving this impeccable result.
- When you use the hover effect and cursor: pointer on an element, it usually implies interactivity. To enhance user experience, consider wrapping the name of the "HTML & CSS foundations" text in an
<a href="#">
tag. This way, users can click on it, expecting some action, like navigating to a page with more information about the fundamentals
- The
<section>
tag is typically used for grouping related content, but it's not the most appropriate choice for containing only a image.
I hope you find it useful! ๐ Above all, the solution you submitted is great!
Happy coding!
Marked as helpful1@fantastizeey1Posted 10 months agothanks for the feed back i really appreciate them ill try that moving forward@MelvinAguilar
1 - @danielmrz-devPosted 10 months ago
Hello @fantastizeey1!
Your project looks great!
I noticed that you used
margin
to place the card in the middle of the page. Here's a very efficient way to center the card:- Apply this to the body (in order to work properly, you can't use position or margins):
body { min-height: 100vh; display: flex; justify-content: center; align-items: center; }
I hope it helps!
Other than that, great job!
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord