@R3ygoski
Posted
Hello Leanne, congratulations on completing your project! It looks almost identical to the proposed design, and it's very well done.
I'd like to offer you some tips regarding your IDs. Typically, when we're styling elements, we rarely use IDs. They're usually reserved for very specific cases. It's more appropriate to use classes for styling, and you could create a global style like container
and then add something unique to that element, like class="container card-image"
.
Another thing I'd like to suggest is about your HTML. It's well-structured, but it lacks some semantics. For example, you could consider replacing this div: <div class="container" id="card-image">
with a <figure>
tag, as it's more semantic and relates better to this type of image, which is the main image of the page.
Again, congratulations! Keep up the good work; your project is really well done. Keep practicing and improving. If anything I said isn't clear, please comment below, and I'll try to help as best as I can.
Marked as helpful