Design comparison
Solution retrospective
I will be glad for any feedback.
Community feedback
- @danielmrz-devPosted 10 months ago
Hello @JaroslavHosovsky!
Your solution looks excelent!
I have just one suggestion:
- In order to make your HTML code more semantic, don't skip heading levels - start with
<h1>
, then use<h2>
, and so on. Unlike what most people think, it's not just about the size and weight of the text.
📌 The
<h1>
to<h6>
tags are used to define HTML headings.📌
<h1>
defines the most important heading.📌
<h6>
defines the least important heading.📌 Only use one
<h1>
per page - this should represent the main heading/title for the whole page.This change has little or not effect at all on the project, but it makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.
I hope it helps!
Other than that, you did a great job!
Marked as helpful0 - In order to make your HTML code more semantic, don't skip heading levels - start with
- @Kulyk-VolodymyrPosted 10 months ago
Hi, good job!
Component is partialy hidden on the mobile horizontal screen. This can be fixed by changing
height: 100vh
tomin-height: 100vh
inbody
. You can also addpaddind
tobody
to add space around the card.Marked as helpful0 - @KarimAyman97Posted 10 months ago
Hi , Great Job! simple recommendation each <img> should have alt attribute which describes the image
<img src="img/illustration-article.svg" alt="Illustration for the article" />
this ensures accessibility and also improves overall SEO
i hope it helps !
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord