Design comparison
SolutionDesign
Community feedback
- @tdimnetPosted 6 months ago
Hi @amirhirx,
Great job with your project! I read both your HTML and CSS code and it looks great!
Here are some feedback if you want to improve your project:
- You could be better with your
alt
attributes. I am thinking aboutalt="Thumbnail"
andalt="avatar"
. For example, for the second one, you could replace it byalt="Greg Hooper"
. By default, screen readers will reader *Image of Greg Hooper". - You could use normalize.css or a reset css file in order to make your project looks more consistent on different web browsers. Here are some interesting links if you want to learn more about this concept:
- https://necolas.github.io/normalize.css/
- https://css-tricks.com/an-interview-with-elad-shechter-on-the-new-css-reset/
- https://www.joshwcomeau.com/css/custom-css-reset/
- I also noticed you used
float: right;
. This is okay but for your information, we tend not to use float anymore 🙂.
Other than that, this is really solid work!
Have a nice day, Tom.
0 - You could be better with your
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord