Blog preview card

Community feedback

• 

  Daniel 🛸•44,310

  @danielmrz-devPosted 11 months ago

  Hello William!

  Your solution looks great!

  I have a couple of suggestions:

  • Since you set grid to the body, but you didn't set the size of the rows, your footer is pushing your card up a little bit. You can prevent that from happening adding this to the body:

  grid-template-rows: 90% 1fr;
  

  Then your card will always occupy 90% of the space and the footer will adapt in the remaining space.

  • Also, for semantic reasons, and since that is the main title of the screen, you can replace the <p> with <h1>. Unlike what most people think, it's not just about the size and weight of the text.

  📌 The <h1> to <h6> tags are used to define HTML headings.

  📌 <h1> defines the most important heading.

  📌 <h6> defines the least important heading.

  📌 Only use one <h1> per page - this should represent the main heading/subject for the whole page. Also, do not skip heading levels - start with <h1>, then use <h2>, and so on.

  I hope it helps!

  Marked as helpful

  1

  ---

  

  William•190

  @tuaPuan83Posted 11 months ago

  Thank you for you feedback @danielmrz-dev

  0