Design comparison
Solution retrospective
Any feedback is greatly appreciated! :)
Community feedback
- @rayaattaPosted 10 months ago
Hi there👋, nice solution I only have two tips I think you need 1.* In your css you have this code snippet
body { height: 100lvh;
.I think this would be better asmin-height: 100vh;
2. In your html I noticed
<span class="blog__date">Published 21 Dec 2023</span>
When a screen reader is reading the above it will pronounce21 Dec 2023
as it is. This should be wrapped in<time datetime="2023-12-21">21 Dec 2023</time>
This is machine readable therefore it is more accessible. To find out more about the time tag check out this article📑I hope you find it useful
That aside your solution is freaking great🤩 Happy coding 🙃
Marked as helpful2@jeeberharter1Posted 10 months ago@rayaatta Thank you so much for the feedback! I made the changes you mentioned above. I didn't know about the time tag. I appreciate you teaching me something new :)
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord