Design comparison
Solution retrospective
Hey everyone, this is my first project. Any feedback to help me improve my code would be much appreciated. Thanks for the help!
Community feedback
- @Mitko90Posted 11 months ago
Hi there, nice solution.
Maybe if you looked again at your
container
.container { max-width: 85%; background-color: var(--Yellow); margin: 200px auto 0; align-content: center; height: 800px; }
You don't need the max-width there to be percentage , also get rid of the
align-content
because it is used for grid containers so it does nothing here. I would also get rid of theheight
since the card inside will have its own height. The yellow background I would put on thebody
tag so the whole page will be yellow. Also on the body you can throwmin-height: 100vh; display: flex; align-items: center; justify-content: center;
This will center your card on the page
Hope I was helpful
Marked as helpful2
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord