Oleg• 80
@scobox
Posted
Good result! I like the transition properties you added! Things requiring attention:
- I prefer not to use <body> as a flex container. I suggest wrapping the whole card into a wrapper, for example div with ".card" class, and use ".container" as a flex container.
- I would add "margin: 0 10px; to ".card"( in your case ".container") to make small gap on the sides of the card on small resolutions.
- also on small resolutions card does not displayed correctly as you set up "width:340px". You should have used "max-width:340px" instead to fit the card to mobile screens.
- And last one: for all internal elements you set up margins to make the gap between each element and left edge of the card. In such cases I would use "padding-left: 24px" on ".container" element and remove all paddings on internal elements.
Marked as helpful
0
