Design comparison
SolutionDesign
Solution retrospective
What are you most proud of, and what would you do differently next time?
Managing responsive text without the use of media queries.
What challenges did you encounter, and how did you overcome them?Sizing text without the use of media queries. The clamp() property was fun to learn.
What specific areas of your project would you like help with?I am happy with the overall layout, however, I would appreciate input on how I can improve my code.
Community feedback
- @scoboxPosted 5 months ago
Good result! I like the transition properties you added! Things requiring attention:
- I prefer not to use <body> as a flex container. I suggest wrapping the whole card into a wrapper, for example div with ".card" class, and use ".container" as a flex container.
- I would add "margin: 0 10px; to ".card"( in your case ".container") to make small gap on the sides of the card on small resolutions.
- also on small resolutions card does not displayed correctly as you set up "width:340px". You should have used "max-width:340px" instead to fit the card to mobile screens.
- And last one: for all internal elements you set up margins to make the gap between each element and left edge of the card. In such cases I would use "padding-left: 24px" on ".container" element and remove all paddings on internal elements.
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord