Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Blog Preview

@nickster369

Desktop design screenshot for the Blog preview card coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

P

@Islandstone89

Posted

HTML:

  • Every webpage needs a <main> that wraps all of the content, except for <header> and footer>. This is vital for accessibility, as it helps screen readers identify a page's "main" section. Wrap the card in a <main>.

  • I would place the top image in the HTML instead of using background-image in the CSS.

  • You don't need all those divs. Use on div that hold the card content, and one for the bottom section with the image and the name - that is all you need.

  • "Learning" and "Published" are <p> elements. I would use wrap the date in a <time> element:<p>Published <time datetime="2023-12-21">21 Dec 2023</time></p>.

  • "HTML & CSS" is a <h2>, and needs a link inside.

  • The profile image has meaning, so the alt text cannot be empty. I would write "Headshot of Gary Hooper".

  • Never have text in divs alone. Wrap "Greg Hooper" in a <p>.

CSS:

  • Including a CSS Reset at the top is good practice.

  • It is common to have the Variables as the beginning of the stylesheet.

  • At the top, remove html and .bodyContainer as selectors.

  • I like to add 1rem of padding on the body, to ensure the card doesn't touch the edges on small screens.

  • On the body, change height to min-height - this way, the content will not get cut off if it grows beneath the viewport. Remove the min-width.

  • Except for the profile image, remove all widths and heights in px.

  • Remove min-height on .bannerContainer.

  • Add a max-width of around 20rem on the card, to prevent it from getting too wide on larger screens.

  • font-size must never be in px. This is a big accessibility issue, as it prevents the font size from scaling with the user's default setting in the browser. Use rem instead.

  • It is common to set display: block and max-width: 100% on images.

  • Set padding on the card container, instead of on each section. The padding should be equal, so you could write it like this:padding: 24px;.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord