Blog preview

Community feedback

• 

  KapteynUniverse•2,880

  @KapteynUniversePosted 4 months ago

  Hey Praises, nice job.

  Landmarks, (or this page) are essencial for accesibility. Every page needs one main. The main landmark is reserved for the main content of the entire page and should not be used inside a card. Instead of wrapping the text with main, you should wrap the card div with a main.

  You can also change card div with an article tag if you want.

  Since you used flex on the body, you can use justify-content: center; on the body instead of margin: 0 auto;, not much difference tho just for better readability.

  Nice using of max-width, also for better responsiveness; use rem especially for font sizes and media queries.

  I also recommend you to use a modern css reset or you can check Andy Bell's reset too

  Marked as helpful

  0

  ---

  

  praises1•80

  @praises1Posted 4 months ago

  @KapteynUniverse Thank you for the feedback!

  0