Blog preview

Community feedback

• 

  Lucas Carlesso•140

  @lucarlePosted 4 months ago

  I would understand if you had the card as a <article>, but why only the text?

  Overall it seems like you knew how to solve the challenge, and I found interesting the use of utility classes, but some of the values applied differ from the design. Was that a intentional choice, or did you not find them on Figma?

  Also, you didn't include the hover effect.

  Marked as helpful

  1

  ---

  

  Ayman-Hussein•70

  @Astr0n1Posted 4 months ago

  Thanks for your time reviewing my solution and here i will answer your questions:

  • You are right the best practice is to make the whole card as article not only the text as i'm still getting familiar with best usage of semantic elements -the values differ from the design as i estimate it with my eye as i don't use the Figma file for special purposes when the clients cant afford a Ui or the just show you an image and tell they want a familiar object
  • I also didn't know there was a hover effect as i depended only on the design image attached with starter files

  @lucarle

  0

  

  Lucas Carlesso•140

  @lucarlePosted 4 months ago

  @Astr0n1 I'm happy you liked it.

  That's cool, even without Figma you got pretty close to the design.

  1