Design comparison
Solution retrospective
Any help is welcome!
Community feedback
- @DylandeBruijnPosted 4 months ago
@PedroEustaq
Hiya! 👋
Congratulations on your solution, it looks very close to the design! I can tell you put a lot of effort into it.
Things you could improve ✍️
-
I suggest adding a bit of
padding
to yourbody
element so the card has some space around it on smaller viewports. -
You could add a
min-height: 100vh
to yourbody
element so it takes up the full height of the viewport while still being able to grow when the content inside it grows. -
You don't have to put
width: 100vw
on thebody
element. It already takes up the full width of thehtml
tag. Which in turn takes up the full width of the viewport, which is 100vw. -
Try experimenting with CSS variables, they help you make your CSS values more reusable across your code.
-
I suggest using clear descriptive CSS classes like
.card
,.card-title
and.card-description
. -
Try using using relative CSS units like
rem
andem
they make your layout more adaptable. -
Try making your solution more reponsive.
-
I suggest using a
p
tag for "Learning".
I hope you find my feedback helpful! 🌟
Let me know if you have more questions and I'll do my best to answer them. 🙋♂️
Happy coding! 😎
1 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord