Design comparison
Community feedback
- @shwertsPosted 3 months ago
Hi, your solution looks well! Here are how you can improve your solution:
-
Avoid using fixed
height
for container, usemin-height
property instead to not let overflow happen. -
Box shadow's property is this:
x y blur color
; where x & y are element coords offsets, and blur is self-explanatory, every value except for color must have<length>
units (for example:rem
,px
orch
). -
Replace some
div
s with semantic elements as<main>
for container,<article>
for card,<p>
for para element. Also, wrap date time (not includingpublished:
) in a<time>
tag with mandatorydatetime
attribute (don't forget to write value for this attribute like this:"YYYY-MM-DD"
).
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord