Design comparison
Solution retrospective
I am not sure when to use the SPAN tag... Can you tell me if I used it right?
Community feedback
- @Alokray007Posted 9 months ago
Hello there ๐
Good job on completing the challenge !
Your project looks really good!
I have a suggestion about your code that might interest you.
There is an very useful browser extension called Perfect Pixel that allow you compare with the design image and thus see the exact dimensions. I recommend it to you.
๐ Tags like <div> and <span> are typical examples of non-semantic HTML elements. They serve only as content holders but give no indication as to what type of content they contain or what role that content plays on the page. This tag change does not impact your project visually and makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.
I hope this suggestion is useful for future projects.
Other than that, great job!
Happy coding.
Marked as helpful1 - @IrinaKrdmvaPosted 9 months ago
Thanks a lot for your suggestion on PerfectPixel, it looks amazing. I have gone and installed it.
About the div and span tags... Do you recommend using section instead (div)? Span is not what I usually go to, but I have seen it used in some tutorials that is why I tried it.
I will definitely research about semantic HTML more and apply in future projects.
Again, Thank you.
0@daHattaPosted 9 months ago@IrinaKrdmva
Hi Irina,
Using section, div or span... I struggle sometimes by myself. :)
As section has to be followed by a headline directly I would chose a div in that case.
Definitely worth looking up on semantic HTML.
Other than that, nice implemention!
PS: You used a button for the - what I guess - is the topic pill (Learning). It might look like a button, but if it should be linked, I recommend an a-tag.
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord