Design comparison
Solution retrospective
I'm most proud of finally completing the challenge Next time id like to improve on the time am taking in completing a challenge
What challenges did you encounter, and how did you overcome them?The challenge I countered was assigning size to the main image, I overcame it by realizing that the image was at fixed size
What specific areas of your project would you like help with?Any feedback on the codes that would make my webpage more responsive or better codes to be used instead of the one I used. THANK YOU
Community feedback
- @StroudyPosted about 1 month ago
Exceptional work! You’re showing great skill here. I’ve got a couple of minor suggestions that could make this stand out even more…
-
Using a
<main>
tag inside the<body>
of your HTML is a best practice because it clearly identifies the main content of your page. This helps with accessibility and improves how search engines understand your content. -
These
<span>
should really have semantic tags like headings (<h1> to <h6>
) and paragraphs (<p>
) convey structure and meaning to content, improving accessibility, SEO, and readability by helping search engines and screen readers interpret the content.
<span>Learning</span>
-
For future project, You could download and host your own fonts using
@font-face
improves website performance by reducing external requests, provides more control over font usage, ensures consistency across browsers, enhances offline availability, and avoids potential issues if third-party font services become unavailable. Place to get .woff2 fonts -
Using a full modern CSS reset is beneficial because it removes default browser styling, creating a consistent starting point for your design across all browsers. It helps avoid unexpected layout issues and makes your styles more predictable, ensuring a uniform appearance on different devices and platforms, check out this site for a Full modern reset
-
Line height is usually unitless to scale proportionally with the font size, keeping text readable across different devices. Best practice is to use a unitless value like
1.5
for flexibility. Avoid using fixed units likepx
or%
, as they don't adapt well to changes in font size or layout.
I hope you’re finding this guidance useful! Keep refining your skills and tackling new challenges with confidence. You’re making great progress—stay motivated and keep coding with enthusiasm! 💻
Marked as helpful0@mth-aniPosted about 1 month ago@Stroudy Thanks I really appreciate. Ill my best on improving on my next challenge.
1@StroudyPosted about 1 month agoHey @mth-ani, I will try to keep an eye out for you next solution, I hope you implement some of these changes, You got this bro!💪
Marked as helpful0 -
- @briangestebanPosted about 1 month ago
Hi @mth-ani,
Great job on the challenge.
I would suggest to use semantic elements next time. This will give your users a better accessible website.
Why semantic elements? One example scenario would be, if your user uses a screen reader, screen reader reads your website and translate it into speech so if your user is blind they could still use and understand your website and it's content.
With <div> elements or other non-semantic elements, it's not really that useful for the screen reader to understand because it doesn't have meaning. Unlike to it's counterpart, sematic elements. This gives the screen reader a better understanding of your website and content, and this will help your user to navigate better as the screen reader knows which part is the <main> content, <section> part of a bigger content, etc.
In some cases, you might need to use a non-semantic element. On those scenarios, you could apply some role, aria-label, etc.
To get better and deeper understanding on these, you could check the references attached below.
References:
Hope these helps. Happy Coding!
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord