Blog Card Submission

Community feedback

• 

  Daniel 🛸•44,310

  @danielmrz-devPosted 9 months ago

  Hello @davidptclark!

  Your solution looks great!

  I have a couple of suggestions (about semantic HTML) for improvement:

  📌 First: Use <main> to wrap the main content instead of <div>.

  Think of <div> and <span> in HTML like plain boxes or placeholders. They're handy for holding content, but they don't tell us anything about what's inside or what it's meant for on the webpage.

  📌 Second: Use <h1> for the main title instead of <h2>.

  Unlike what most people think, it's not just about the size and weight of the text.

  • The <h1> to <h6> tags are used to define HTML headings.
  • <h1> defines the most important heading.
  • <h6> defines the least important heading.
  • Only use one <h1> per page - this should represent the main heading/title for the whole page. And don't skip heading levels - start with <h1>, then use <h2>, and so on.

  All these tag changes may have little or any visual impact but they make your HTML code more semantic and improve SEO optimization as well as the accessibility of your project.

  I hope it helps!

  Other than that, great job!

  Marked as helpful

  1
• 

  Noel Hoppe•350

  @noelhoppePosted 9 months ago

  Hi, some suggestions:

  1. Try to use HTML5 semantic elements like main, section, article, footer instead of non-semantic elements like div
  2. "HTML & CSS Foundations" should be a <h1>
  3. "Leraning" should be a <p>
  4. Remove padding-left: 20px from div.cardMatter and add padding-left: 20px to div.cardWrapper
  5. Replace height: 100% in div.container with min-height: 100vh Great work

  Marked as helpful

  1