Design comparison
Solution retrospective
I'm most proud of successfully creating a responsive design that adapts well to different devices.
Next time, I would explore using CSS Grid in combination with Flexbox for more complex layouts and consider adding subtle animations to enhance user experience.
What challenges did you encounter, and how did you overcome them?I encountered challenges with making the card fully responsive without stretching the content. I overcame them by using a combination of Flexbox and proper max-width
settings, along with media queries, to maintain the design's proportions on all screen sizes.
I would like help with optimizing the CSS for better performance and maintainability, particularly with using advanced techniques like CSS Grid alongside Flexbox. Additionally, any suggestions for improving the visual design or enhancing the user experience with animations would be appreciated.
Community feedback
- @StroudyPosted about 2 months ago
Hey, Great job with this solution you should be proud, A few things I noticed,
- Missing a
<meta>
description tag for SEO purposes, - Setting a height and width attribute to your
<img>
will increase performance to reduce layout shifts and improve CLS, It reserves the space on the page for the image, - Setting a height and width attribute to your
<img>
will increase performance to reduce layout shifts and improve CLS, It reserves the space on the page for the image, You should add afont-display: swap;
property to your@font-face
, Leverage the font-display CSS feature to ensure that text is user-visible while web fonts are loading, Increasing performance. - Having better
alt=""
descriptions for accessibility is a must check this out Write helpful Alt Text to describe images, - You should apply a full modern reset to make things easier as you build, check out this site for a Full modern reset
- Using a naming convention like BEM, Using proper naming will prepare you for the changes in design of the website.
- Using
max-width: 100%
ormin-width: 100%
is way more responsive then justwidth:100%
, check out this article also from the same Frontend mentor dev responsive-meaning, she goes into more detail. - You should avoid using
px
as it is an absolute unit and not a responsive unit likerem
orem
, You should look at this article from a Frontend mentor dev, Why font-size must NEVER be in pixels. - Another great resource for px to rem converter.
- Line height is usually unitless instead of
line-height: 150%;
should useline-height: 1.5;
this means it is 1.5 x the font-size, unitless value ensures that the line height will scale proportionately.
I hope you found some of this information helpful, You should give the articles a good read and I look forward to seeing some more from you, Happy coding! 💻
0 - Missing a
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord