@DylandeBruijn
Posted
@Ibtehaj-Ali-1
Hiya! π
Congratulations on your solution, it looks very close to the design! I can tell you put a lot of effort into it.
Things you could improve βοΈ
-
I suggest adding a bit of
padding
to yourbody
element so the card has some space around it on smaller viewports. -
Try using semantic HTML elements like
main
,section
andarticle
. -
Try using using relative CSS units like
rem
andem
they make your layout more adaptable. -
Be careful with setting a fixed
width
andheight
on your elements. If the content in these elements grows beyond these restrictions youβll run into overflow issues. Keeping theheight
atauto
- whichblock
elements are by default - will be fine in most cases.
@media screen and (max-width: 375px) {
.card {
width: 327px;
height: 501;
}
}
I would remove this media query, it would make your solution more responsive.
- You donβt need to put
width: 100%
onblock
elements, they already take up the full width of their parents by default.
I hope you find my feedback helpful! π
Let me know if you have more questions and I'll do my best to answer them. πββοΈ
Happy coding! π
Marked as helpful