Design comparison
Solution retrospective
This second project was way easier than the first one, I am proud of my developments and am getting much better at using CSS.
What challenges did you encounter, and how did you overcome them?I didn't encounter any hard challenges during this project. It was easy.
Community feedback
- @DylandeBruijnPosted 4 months ago
@Ibtehaj-Ali-1
Hiya! π
Congratulations on your solution, it looks very close to the design! I can tell you put a lot of effort into it.
Things you could improve βοΈ
-
I suggest adding a bit of
padding
to yourbody
element so the card has some space around it on smaller viewports. -
Try using semantic HTML elements like
main
,section
andarticle
. -
Try using using relative CSS units like
rem
andem
they make your layout more adaptable. -
Be careful with setting a fixed
width
andheight
on your elements. If the content in these elements grows beyond these restrictions youβll run into overflow issues. Keeping theheight
atauto
- whichblock
elements are by default - will be fine in most cases.
@media screen and (max-width: 375px) { .card { width: 327px; height: 501; } }
I would remove this media query, it would make your solution more responsive.
- You donβt need to put
width: 100%
onblock
elements, they already take up the full width of their parents by default.
I hope you find my feedback helpful! π
Let me know if you have more questions and I'll do my best to answer them. πββοΈ
Happy coding! π
Marked as helpful0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord