Design comparison
Solution retrospective
I am proud of the fact that I learned and used CSS variables in this project.
Community feedback
- @DylandeBruijnPosted 4 months ago
@hsfarid
Hiya! π
Congratulations on your solution, it looks very close to the design! I can tell you put a lot of effort into it.
Things I like about your solution π
- Clear descriptive CSS classes
- Use of CSS custom properties
Things you could improve βοΈ
-
I suggest adding a bit of
padding
to yourbody
element so the card has some space around it on smaller viewports. -
You could add a
min-height: 100vh
to yourbody
element so it takes up the full height of the viewport while still being able to grow when the content inside it grows. -
Try using semantic HTML elements like
main
,section
andarticle
. -
You donβt have to wrap your image in a separate
div
, itβs possible to style it directly to achieve the same result.
I hope you find my feedback helpful! π
Let me know if you have more questions and I'll do my best to answer them. πββοΈ
Happy coding! π
Marked as helpful0@hsfaridPosted 4 months ago@DylandeBruijn Thanks for your honest and remarkable feedback. This will go a long way.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord