Blog Card Preivew

Community feedback

• 

  Dylan Heslop•1,570

  @dylan-dot-cPosted about 19 hours ago

  Well done on this challenge, you did good!

  There are a few things you'll need to master before going on to harder challenges as these are the key fundamentals of web development.

  • You didn't use any semantic HTML. It's important as it helps screen readers to easily understand the webpage for disabled people. So you need to use elements like main and article to get rid of the landmarks error up there.
  • You also didn't use any heading elements like h1/h2/h3... It's important to have those so screen readers can know what's the most important topic or what the content is for.
  • Back again on screen readers, for illustration images that don't really have much meaning(just there for styling purposes) don't really need an alt tag as it's not important to the main content since if the image wasn't there, the screen reader wouldn't be missing anything related to the content.
  • Screen Reader again... It's not good practice to use br tags in webdev unless it's actually needed to break a paragraph or content in your website. On screen readers it will pronounce them as break and that's not good. If you want spacing between elements I consider you use margin or make it a flex container and use gap.
  • Responsiveness: website isn't responsive as it doesn't look proper on all screen sizes, especially mobile screens. You should always check that using the developer tools in ur browser. Also don't use percentages or fixed height as it will cause overflow if the content can't fit on a small screen. Instead use max/min-width/height to avoid stretching in certain areas.
  • font family: in the real world it would be better if you name the font the actual name of the font as if I wanted to contribute to your code and I see 'myFont' I don't know what that is... Is it a custom font that you made? Is it on Google fonts? Where is the file for it? So I suggest that you just put the right name for it.

  Overall this is an easy challenge but the main purpose of these is not to just complete them and move on but to test your semantic HTML skills and how you write code on a smaller level.

  If you write good code on a smaller level, you can do so with a larger codebase.

  But if you write bad code on a smaller level, how can I trust you won't do the same on more complex projects.

  I'm sorry if I may seem harsh, but don't let me discourage you, its important to be able to take constructive feedback in the workforce so you can get better and not look at someone criticizing you.

  Anyways you can message me here and also look at my solution to see how I did it.

  All the best and take care.

  Marked as helpful

  0

  ---

  

  VADER900000•60

  @VADER900000Posted about 16 hours ago

  @dylan-dot-c hi so for the semantic html I will try my best on the next project I'll also make sure to use heading the br I will try to completely eliminate as for the responsiveness I added that later on when I learned how to and I'll try to name things better this is my fault anyway thank u for ur feedback it helps alot more than u think

  0