Design comparison
Solution retrospective
Please take a look and let me know how it reads on your end. Let me know if there are issues with font-size or margins and paddings.
Do transitions from one screen size to another make sense, or is there something you would recommend?
Community feedback
- @PJIceskullPosted 11 months ago
Hey there, you did a pretty good job with your solution, but you're missing your hover selection for the <h1> and box-shadow.
I also don't think you have added margins to your <main> since you already using Flexbox in your body.
Another nitpick from me is that I think that the border should only be 1px instead of 2px.
Marked as helpful0 - @MariaValentinovaPosted 11 months ago
I think you could optimize your code. I don't understand why you're accommodating so many screen size options. In the documentation, it says it's intended for mobile screens of 375px and desktops of 1440px, I believe. This way, there would be much less code. You should pay more attention to proportions: border-radius, and margins. Good use of the CSS flex property!
Marked as helpful0 - @michiganprogrammerPosted 11 months ago
one thing you missed was making the learning button change color when hovered over.
You can use :hover selector in css to achieve that.
Hope that helps
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord