Design comparison
SolutionDesign
Solution retrospective
What are you most proud of, and what would you do differently next time?
I was able to build the project
What challenges did you encounter, and how did you overcome them?Encountered problem with css but i was able to resolve it using stack overflow
What specific areas of your project would you like help with?None
Community feedback
- @AchigyusPosted 6 months ago
Hi mate.
Congrats on finishing the challenge, you did a good job. I just have a few recommendations
- The link you submitted to view your code doesn't actually link to the code, making sure the proper link is posted would make it easier to review your submission and for you to receive feedback.
- For the image component, you used a
div
and set it's background to the image, it would have been more appropriate to use animg
tag. - You wrapped the learning element in a
b
tag, it would be more appropriate to use thefont-weight
css property to achieve the desired effect. This element could also have been abutton
or ana
tag. - It would be more appropriate to set the title as a
h1
tag rather than ah2
. - The
text-shadow
property added to the blog description makes the text difficult to read, you could consider removing it as it is not part of the design.
Thank you.
Marked as helpful0@dynamic109Posted 6 months ago@Achigyus Thanks for the suggestions, will implement these right away
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord