Blog Card component challenge

Community feedback

• 

  P

  Øystein Håberg•10,650

  @Islandstone89Posted 10 months ago

  HTML:

  • A <h2> should never appear before a <h1>, and "Learning" is also not a heading. It could be a <a>, or just a <p>.

  • I would wrap the date in a <time> tag: <time datetime="2023-12-21">21 Dec 2023</time>.

  • Headings are meant to introduce new content. Since there isn't any content following "Gary Hooper", I would make it into a <p>.

  • The alt text of the profile image must be descriptive. Write something like: "Headshot of Gary Hooper".

  CSS:

  • Always include a proper CSS Reset at the beginning.

  • Move the properties on html to the body.

  • max-width on the card should be in rem.

  • I would add padding: 1rem on the body, and remove the media query. When you do need them, they must be in rem instead of px. Also, it is best practice to do mobile styles as the default, and use media queries for larger screens.

  Marked as helpful

  0

  ---

  

  Shubham Rawat•60

  @shubham00111Posted 10 months ago

  @Islandstone89 Thanks Øystein Håberg for the feedback. I'll follow them for sure.

  1